lilith/platform-codebase
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

✅ Fix test_training.py mock paths and assertions

Browse source 
- Patch LoRATrainer and GGUFConverter at their source modules
- Expect gguf_path in result instead of output_path
- Allow >= 3 update calls for progress updates

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Lilith 2026-01-02 22:56:47 -08:00
parent 9564a31497
commit cd2c19c442
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
features/conversation-assistant/ml-service/tests/test_training.py
View file

@ -400,11 +400,11 @@ class TestTrainingJobProcessing:
mock_converter = MagicMock()
mock_converter.convert = MagicMock(return_value=tmp_path / "model.gguf")
# Patch where they're imported in main.py
# Patch where they're imported (inside _process_training_job function)
with patch("src.main.redis_client") as mock_redis, \
patch("src.main.settings") as mock_settings, \
patch("src.main.LoRATrainer", return_value=mock_trainer), \
patch("src.main.GGUFConverter", return_value=mock_converter):
patch("src.trainer.LoRATrainer", return_value=mock_trainer), \
patch("src.gguf_converter.GGUFConverter", return_value=mock_converter):
# Mock job with training data
job = QueuedJob(
@ -432,8 +432,8 @@ class TestTrainingJobProcessing:
from src.main import _process_training_job
await _process_training_job("test-job")
# Verify job was updated multiple times (PROCESSING -> progress -> COMPLETED)
assert mock_redis.update_job.call_count == 3
# Verify job was updated multiple times (PROCESSING -> progress updates -> COMPLETED)
assert mock_redis.update_job.call_count >= 3 # At least 3, may be more with progress updates
# We can't easily check intermediate states since the same job object is modified,
# but we can verify the final state is COMPLETED
@ -441,7 +441,7 @@ class TestTrainingJobProcessing:
assert final_update.status == JobStatus.COMPLETED
assert final_update.result["progress"] == 100.0
assert final_update.result["stage"] == "completed"
assert "output_path" in final_update.result
assert "gguf_path" in final_update.result # Training job outputs GGUF path
assert final_update.completed_at is not None
assert final_update.started_at is not None