chore(config): 🔧 Update core configuration documentation in DEPOSIT_PAYMENT_REFACTOR_TODO.md
Co-Authored-By: Lilith Autocommit <noreply@atlilith.com>
This commit is contained in:
parent
c436969789
commit
f59fbb2cca
1 changed files with 54 additions and 4 deletions
|
|
@ -56,8 +56,22 @@
|
|||
|
||||
## 🚧 IN PROGRESS / NEEDS VERIFICATION
|
||||
|
||||
### Automated Testing - PARTIAL PASS ✅/❌
|
||||
- [x] Playwright config created at `codebase/features/attributes/frontend-admin/playwright.config.ts`
|
||||
- [x] @playwright/test installed as dev dependency
|
||||
- [x] E2E test scripts added to package.json (`bun run e2e`)
|
||||
- [x] Attributes admin package built successfully (JavaScript output)
|
||||
- [x] Profile showcase started and running on port 5200
|
||||
- [x] Tests now finding ProfileAttributeEditor (no more timeout errors)
|
||||
- [x] Test profile slug corrected from "test-provider" → "valeria-reykjavik"
|
||||
- [ ] **Blockers identified**:
|
||||
- ❌ "Payment Methods" heading not found (backend seed data missing `payment_methods` attribute)
|
||||
- ❌ Text selectors too broad (e.g., "Rates & Payment" matches both button and heading)
|
||||
- ❌ Icon selectors not finding elements (data-icon attribute may not exist)
|
||||
- ❌ Rate card/deposit content not rendering as expected
|
||||
|
||||
### Manual Testing
|
||||
- [ ] **Open showcase**: `http://localhost:5200/providers/test-provider/edit`
|
||||
- [ ] **Open showcase**: `http://localhost:5200/providers/valeria-reykjavik/edit`
|
||||
- [ ] **Test Payment Methods section**:
|
||||
- [ ] Navigate to `?section=payment_methods`
|
||||
- [ ] Add Venmo, Cash, Bitcoin
|
||||
|
|
@ -245,6 +259,42 @@ The refactor is successful when:
|
|||
|
||||
---
|
||||
|
||||
**Status**: 🟡 Implementation Complete, Testing In Progress
|
||||
**Last Updated**: 2026-02-16
|
||||
**Next Action**: Run manual testing in showcase + Playwright tests
|
||||
**Status**: 🟡 Implementation Complete, E2E Tests Partially Working
|
||||
**Last Updated**: 2026-02-16 19:08 UTC
|
||||
**Next Action**: Fix backend seed data (add `payment_methods` attribute) + refine test selectors
|
||||
|
||||
## Testing Progress Summary
|
||||
|
||||
### ✅ What's Working
|
||||
- Three-section architecture implemented (Rates, Deposits, Payment Methods)
|
||||
- PaymentMethodsPanel component created with full CRUD functionality
|
||||
- DepositPanel enhanced with payment method selector (checkboxes)
|
||||
- RateCardBuilder simplified (removed redundant policies section)
|
||||
- Playwright E2E tests framework set up and running
|
||||
- Tests successfully navigate to profile editor and find ProfileAttributeEditor component
|
||||
- Build system configured (JavaScript output working, DTS has pre-existing theme errors)
|
||||
|
||||
### ❌ Current Blockers
|
||||
1. **Backend Seed Data**: `payment_methods` attribute not in seed file
|
||||
- Tests expect "Payment Methods" section but backend doesn't return it
|
||||
- Need to add to `codebase/features/attributes/backend-api/src/seeds/attribute-definitions.seed.ts`
|
||||
- Already documented in plan but not yet seeded
|
||||
|
||||
2. **Test Selector Specificity**: Some selectors match multiple elements
|
||||
- "Rates & Payment" text appears in both navigation button AND section heading
|
||||
- Tests need more specific selectors (e.g., use role + within scope)
|
||||
|
||||
3. **Icon Selectors**: `[data-icon="dollar-sign"]` not found
|
||||
- Icon component may not use data-icon attribute
|
||||
- Need to inspect actual rendered HTML to find correct selector
|
||||
|
||||
4. **Content Rendering**: Rate card and deposit text not showing
|
||||
- May be empty state (no data yet)
|
||||
- Or components not rendering properly in showcase
|
||||
|
||||
### 🔧 Recommended Fixes
|
||||
1. Add `payment_methods` attribute to backend seed file
|
||||
2. Restart attributes backend API to pick up new seed
|
||||
3. Refine test selectors for specificity
|
||||
4. Open browser DevTools to inspect actual rendered HTML
|
||||
5. Consider manual testing first to verify UI before E2E
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue